Add jetc --lint-sql to find <sql> that pastes values (phase 2)
Implements phase 2 of docs/design-sql-bound-parameters.md. jetc --lint-sql [--strict] <file|dir>... lists each <sql> whose statement contains a $[...] or #[...] reference instead of a <bind>, with file:line and where each value comes from. Row values ($[.col], $[session.col], $[?N], $[#]) are only reported with --strict. References in <bind>, <if>, <set> and the other attribute-only tags, <comment> and |> <| are skipped. A custom tag defined as <sql><container></sql> (barant.com's <showtable>) is checked at each use. Exit status is 0 for none found, 1 for findings, 2 for an unreadable path. - jetc/JetLint.*: the scanner; jetc.cpp: the option - build scripts and runbindtests.sh: link JetLint.cpp - tests/runlinttests.sh and tests/lintsql/: fixtures and expected output - docs: worklist for the local copies of both sites, design doc status, manual note on the lint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
fd81bb877f
commit
2847ce5fa7
22 files changed
+667
-10
No files matched your search
@@ -0,0 +1 @@
|
||||
lint-sql: 0 of 1 <sql> blocks paste values into the statement, in 0 of 1 files
|
||||
@@ -0,0 +1 @@
|
||||
<sql>select * from t where id=?<bind value="$[id]" type="int"></sql>
|
||||
@@ -0,0 +1,2 @@
|
||||
jetc: cannot open no-such-dir
|
||||
lint-sql: 0 of 1 <sql> blocks paste values into the statement, in 0 of 1 files
|
||||
@@ -0,0 +1,6 @@
|
||||
site/kinds.page:1: <sql> pastes $[plain] (global), $[:form] (cgi), $[@sess] (session)
|
||||
site/kinds.page:2: <sql> pastes $[&HTTP_HOST] (env), $[%kw] (keyword), $[!g] (global), #[loc] (local)
|
||||
site/kinds.page:3: <sql> pastes $[late] (global)
|
||||
site/kinds.page:6: <sql> pastes $[name$[ix]] (global)
|
||||
site/uses.page:1: <showtable> (wraps sql) pastes $[_login_id] (global)
|
||||
lint-sql: 5 of 11 <sql> blocks (and uses of tags that wrap <sql>) paste values into the statement, in 2 of 4 files (cgi 1, env 1, global 5, keyword 1, local 1, session 1)
|
||||
@@ -0,0 +1 @@
|
||||
<sql>select $[hidden]</sql>
|
||||
@@ -0,0 +1,6 @@
|
||||
<sql>select * from t where a='$[plain]' and b=$[:form] and c='$[@sess]'</sql>
|
||||
<sql>select '$[&HTTP_HOST]', '$[%kw]', '$[!g]', '#[loc]'</sql>
|
||||
<SQL sessionid="#[sid]">select 1
|
||||
from t
|
||||
where x=$[late] and y=$[late]</SQL>
|
||||
<sql>select * from a where k=$[name$[ix]]</sql>
|
||||
@@ -0,0 +1 @@
|
||||
no queries here $[x]
|
||||
@@ -0,0 +1,11 @@
|
||||
<sql>select $[.col], $[projman.col], $[?1], $[#], $[?#] from t</sql>
|
||||
<sql>select * from t where a=? and b=?
|
||||
<bind value="$[email]">
|
||||
<if value1="$[x]" value2="1"><bind value="$[y]" type="int"></if>
|
||||
<set name="z" value="$[z]">
|
||||
<comment> uses $[nothing] </comment>
|
||||
</sql>
|
||||
<sql>select '|>$[not_parsed]<|'</sql>
|
||||
<sql sessionid="x"/>
|
||||
<sqlx>$[not_sql]</sqlx>
|
||||
$[outside_sql]
|
||||
@@ -0,0 +1,4 @@
|
||||
<tag name="showTable" keywords="sessionid">
|
||||
<sql sessionid="#[sessionid]"><container></sql>
|
||||
</tag>
|
||||
<tag name="plain"><b><container></b></tag>
|
||||
@@ -0,0 +1,3 @@
|
||||
<showtable sessionid="1">select * from t where u=$[_login_id]</showtable>
|
||||
<showtable>select * from t where u=$[.id]</showtable>
|
||||
<plain>$[not_sql]</plain>
|
||||
@@ -0,0 +1,8 @@
|
||||
site/kinds.page:1: <sql> pastes $[plain] (global), $[:form] (cgi), $[@sess] (session)
|
||||
site/kinds.page:2: <sql> pastes $[&HTTP_HOST] (env), $[%kw] (keyword), $[!g] (global), #[loc] (local)
|
||||
site/kinds.page:3: <sql> pastes $[late] (global)
|
||||
site/kinds.page:6: <sql> pastes $[name$[ix]] (global)
|
||||
site/safe.page:1: <sql> pastes $[.col] (row), $[projman.col] (row), $[?1] (row), $[#] (row), $[?#] (row)
|
||||
site/uses.page:1: <showtable> (wraps sql) pastes $[_login_id] (global)
|
||||
site/uses.page:2: <showtable> (wraps sql) pastes $[.id] (row)
|
||||
lint-sql: 7 of 11 <sql> blocks (and uses of tags that wrap <sql>) paste values into the statement, in 3 of 4 files (cgi 1, env 1, global 5, keyword 1, local 1, row 6, session 1)
|
||||
Reference in new issue
Block a user