Brad Arant
b0cadc3f08
JetCore engine (Tag.cpp/.h, Global.cpp/.h, __*.cpp tag classes): - Numerous __mysql.cpp connection-pooling correctness fixes (stale result sets, double-indirection sessionid bugs, field caching, pool keying) and a session-registration-before-connection-confirmed ordering fix (dangling pointer on a failed connect) - Tag.cpp: large body of fixes to the tag-dispatch/container-scanning logic (bare-name fallback, database aliasing, single-quote handling, @-prefix session variable resolution, TAGDEF caching, nested split-tag scanning for if/while/until/ifrow so an inner one doesn't corrupt an outer one's own boundary scan) plus the process-first rendering order fix (a <process> now runs before <checksession>/page resolution, fixing a real "blank page after successful login" bug) - Global.h/.cpp: added imapSessions (parallel to the existing __mysql* session map) for the new <imap> tag family - __whiledir.cpp/__include.cpp: caching and directory-name-aliasing fixes - __call.cpp/.h: fixed a dangling-pointer bug - __write.cpp: fixed an O_WRONLY-only open that couldn't create a new file - __ifrow.cpp/__sql.cpp: fixed the same sessionid double-indirection bug __mysql.cpp had (resolveKeyword's result was being used as a map key lookup instead of the resolved value itself) jetc compiler (jetc/JetParser.cpp/.h, JetCodegen.cpp/.h, JetAST.h, jetc.cpp, build-shared.sh, build-compiled.sh): - Parser fixes: inline <include>, nested-quote handling, void-tag recognition - Codegen fixes and expanded AST support - build-shared.sh: atomic rename into place for a freshly-built .jtc (a live server dlopen()ing the same path mid-rebuild was corrupting its own already-mapped view of the old file) and a staleness check so a cached JetCore .o doesn't silently keep serving yesterday's fixes forever - Added -lssl to both build scripts' link lines (needed once the new <imap> tag's client-side TLS code existed - previously nothing in this codebase used OpenSSL's SSL/TLS client API, only libcrypto) Site content (jetc/barant-site/): SPA (fetch-and-swap navigation) rollout across essentially every .page/.jet/.section/.tag/.proc/.method file - dynamic-content fixes, fragment-mode stripping, native $[@name] session variables replacing older mechanisms, and this session's own checkout.page redesign, login start-param redirect fix, and per-page side-menu (menu.bar/$[PAGE].menu) refresh support. Completed the earlier main.css/control.css move from assets/ to assets/images/ (git still showed the old paths as tracked-but-deleted until now). Deliberately left out of this commit: dozens of .pre-<description>- <date> manual backup files (this session's and earlier ones' own before/after snapshots, not meant for permanent history), compiled .jtc build outputs, ad hoc test binaries and scripts under jetc/ (login_asan, wcwc_test, optest2_bin, etc.), and jetc/__pycache__/ - none of these are meant to be tracked; a .gitignore covering them would be worth adding separately.
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
#ifndef ____call_h__
|
|
#define ____call_h__
|
|
|
|
#include "Tag.h"
|
|
#include <vector>
|
|
|
|
namespace jet {
|
|
|
|
class __call : public Tag {
|
|
|
|
public:
|
|
__call(coreutils::ZString &in, coreutils::MString &parentOut, Global &global, Tag *parent, Tag *local);
|
|
|
|
private:
|
|
int pid;
|
|
int status;
|
|
int ix;
|
|
int fdi[2];
|
|
int fdo[2];
|
|
int rc;
|
|
char *argv[50];
|
|
|
|
// Owns the actual character storage argv[] points into. Resolved
|
|
// MStrings used to be created as unnamed temporaries with only
|
|
// their .c_str() pointer kept (argv[ix] = resolveKeyword(arg)
|
|
// .c_str()) - the temporary is destroyed at the end of that same
|
|
// statement, so argv[ix] was a dangling pointer from that point
|
|
// on, read only much later by execvpe() in the forked child.
|
|
// Undefined behavior - confirmed via a real repro: two sequential
|
|
// <call> tags (date, then cp using date's own captured output)
|
|
// corrupted each other's arguments, producing a "cp" invocation
|
|
// that actually ran /bin/date with garbage arguments instead.
|
|
// Reserved to its final size up front (see the constructor) so no
|
|
// push_back can reallocate and invalidate a c_str() pointer
|
|
// already stored in argv[] earlier in the same construction.
|
|
std::vector<coreutils::MString> argStrings;
|
|
|
|
};
|
|
|
|
}
|
|
|
|
#endif
|