Brad Arant
694c6b80a4
Was an unchecked std::vector index (return list[index];). Any malformed/short line - a port scanner, a bot probing the port, or any client sending fewer colon-delimited fields than a given handler indexes via request[N] - reached this with no length check anywhere upstream, across every server built on this class. Depending on build flags that was either undefined behavior or, confirmed live (a real crash log from Zephora's game server), a hard process abort via libstdc++'s own vector bounds assertion: Assertion '__n < this->size()' failed. Throwing instead lets this be caught: every caller that dispatches a parsed request already wraps that dispatch in a try/catch (see CommandList::processRequest()), so a single malformed line is now cleanly rejected instead of taking down the entire server process for every connected player.