tls and master diverged from a July 2024 fork point and never reconciled - tls carries ~19 months of real socket/TLS stability fixes (uninitialized tlsInfo, TCPServer::connectionRequest() unconditionally initializing TLS, the WANT_READ write busy-spin, the console authentication fix from this session), while master independently picked up a Subscription/SubscriptionManager rework (MString-based ownership tracking: owner/ownership/selection/time fields and a working subscriptionOwner() method) that tls never had. Every file both branches touched was resolved by keeping tls's side entirely (Command.h, Socket.cpp, TCPServer.h, TCPSession.cpp/h, TCPSocket.h were pure reformatting on master's side, or an alternate/superseded fix for a bug tls already fixed a different way - e.g. master's TCPSession uuid/alias handling vs tls's existing uuid_unparse-based fix), with two deliberate exceptions: - TCPServer.cpp's constructor was missing the commands.add(subscriptions, "publish"/"subscribe"/"catalog"/...) wiring master had - without it, SubscriptionManager existed but was completely unreachable through the normal command dispatch. Restored on top of tls's TLS-aware constructor. - SubscriptionManager.cpp's "invite" command handler had a real incompatibility: master's version assigned into an `invitee` member typed as coreutils::MString via a stray `(coreutils::MString *)` cast that doesn't match the member's actual (non-pointer) type, and called session.server.getSessionByAlias() against a TCPServer reference - tls made TCPSession::server a pointer (part of removing the separate TCPSession2 class), so that call site no longer compiles as written. Took tls's cleaner local-variable version instead (functionally identical - looks up a session by alias and forwards an invite message) and removed the now-unused `invitee` member from SubscriptionManager.h. One additional compile fix needed after resolving conflicts: Subscription::subscriptionOwners is an MString (master's ownership design), but TCPSession::alias is void* (tls's identity mechanism, unchanged and depended on elsewhere) - MString has an implicit constructor from void* already used successfully elsewhere in this same file (the "publish" handler's Subscription constructor call), but operator== doesn't accept the same implicit conversion, so removeSessionSubscriptions()'s ownership check needed an explicit coreutils::MString(session.alias) construction to compile. Also drops output/main (a stray checked-in compiled binary, already removed on tls) and the doxygen docs/html output (already removed on tls, was carried on master since the fork). Verified: full ServerCore rebuild (./compile) succeeds with zero errors or warnings beyond the one compile fix documented above.
239 lines
8.1 KiB
Plaintext
239 lines
8.1 KiB
Plaintext
#ifndef __Socket_h__
|
|
#define __Socket_h__
|
|
|
|
#include "ZString.h"
|
|
#include <queue>
|
|
#include <mutex>
|
|
#include <sys/epoll.h>
|
|
|
|
namespace core {
|
|
|
|
class EPoll;
|
|
|
|
///
|
|
/// Socket
|
|
///
|
|
/// The core component to managing a socket.
|
|
///
|
|
/// Hooks into the EPoll through the registration and unregistration process and provides a
|
|
/// communication socket of the specified protocol type. This object provides for all receiving
|
|
/// data threading through use of the EPoll object and also provides buffering for output data
|
|
/// requests to the socket.
|
|
///
|
|
/// A program using a socket object can request to open a socket (network or device) and
|
|
/// communicate through the streambuffer interface of the socket object.
|
|
///
|
|
/// The socket side of the Socket accepts EPOLLIN event and will maintain the data in a buffer
|
|
/// for the stream readers to read. A onDataReceived event is then sent with the data received in
|
|
/// the buffer that can be read through the stream. Only sockets that send events to epoll can be
|
|
/// used with this object.
|
|
///
|
|
/// When writing to the stream the data is written into a buffer and a EPOLLOUT is scheduled. Upon
|
|
/// receiving the EPOLLOUT event then the buffer is written to the socket output.
|
|
///
|
|
|
|
class Socket {
|
|
|
|
public:
|
|
|
|
///
|
|
/// Constructor
|
|
///
|
|
/// @param ePoll The EPoll socket descriptor.
|
|
/// @param text A title for this socket.
|
|
///
|
|
|
|
Socket(EPoll &ePoll, std::string text = "");
|
|
|
|
///
|
|
/// Destructor
|
|
///
|
|
|
|
virtual ~Socket();
|
|
|
|
///
|
|
/// Use the shutdown() method to terminate the socket connection and remove resources.
|
|
/// This method is provided to ensure that all destructors are called for all inherited
|
|
/// objects with a virtual destructor.
|
|
///
|
|
|
|
void shutdown(std::string text = "unknown");
|
|
|
|
///
|
|
/// setDescriptor establishes the file descriptor for the socket and registers the socket
|
|
/// on the EPoll controller. setDescriptor will invoke the onRegister() event.
|
|
///
|
|
|
|
void setDescriptor(int descriptor); ///<Set the descriptor for the socket.
|
|
|
|
int getDescriptor(); ///< Get the descriptor for the socket.
|
|
|
|
///
|
|
/// The event received from epoll is sent through the eventReceived
|
|
/// method which will parse the event and call the read and write
|
|
/// callbacks on the socket.
|
|
///
|
|
/// This method is called by the BMAEPoll object and should not be called
|
|
/// from any user extended classes unless an epoll event is being
|
|
/// simulated.
|
|
///
|
|
/// The return value of false will delete the socket object causing the destructors to run.
|
|
/// The return value of true will enable the socket on ePoll to receive more events.
|
|
///
|
|
|
|
bool eventReceived(struct epoll_event event, long long eventId); ///< Parse epoll event and call specified callbacks.
|
|
|
|
///
|
|
/// Write data to the socket.
|
|
///
|
|
|
|
int write(std::string data);
|
|
void write(char *buffer, int length);
|
|
|
|
void output(std::stringstream &out);
|
|
|
|
///
|
|
/// The onRegister method is called before the socket is registered with
|
|
/// ePoll so objects extending the Socket definition can initialize the socket
|
|
/// before receiving events. Evoked when the
|
|
/// descriptor is set using setDescriptor for the socket.
|
|
///
|
|
|
|
virtual void onRegister(); ///< Called before the socket has registered with the epoll processing.
|
|
virtual void onRegistered(); ///< Called after the socket has been registered with epoll processing.
|
|
|
|
virtual void onUnregister();
|
|
|
|
///
|
|
/// ePoll and socket communcation events will be stopped. The default method will
|
|
/// close the socket and clean up the connection. If this is overridden by an
|
|
/// extended object then the object should call this method to clean the socket up.
|
|
///
|
|
|
|
virtual void onUnregistered(); ///< Called when the socket has finished unregistering for the epoll processing.
|
|
|
|
bool needsToWrite();
|
|
|
|
bool reset = false;
|
|
|
|
volatile bool shutDown = false;
|
|
|
|
void enableSocket();
|
|
void disableSocket();
|
|
|
|
protected:
|
|
|
|
EPoll &ePoll; // The EPoll control object.
|
|
|
|
void setBufferSize(int length);
|
|
|
|
int getBufferSize();
|
|
|
|
///
|
|
/// The onConnected method is called when the socket is ready to communicate.
|
|
/// Writing to the socket can begin on this call to initiate a contact with the
|
|
/// remote device.
|
|
///
|
|
|
|
// virtual void onConnected(); ///< Called when socket is open and ready to communicate.
|
|
|
|
///
|
|
/// The connectionRequest method is called to instantiate a new session handler object
|
|
/// and form a new connection to a listening server.
|
|
///
|
|
|
|
virtual void connectionRequest();
|
|
|
|
///
|
|
///
|
|
///
|
|
|
|
// virtual void onDisconnected(); ///< Called when socket is closing and no longer ready to communicate.
|
|
|
|
///
|
|
/// The onDataReceived method is called when the socket has received an event from
|
|
/// epoll and there is data ready to be read from the socket. The default handler
|
|
/// will pull the data and put it into the streambuf for the socket. EPOLLIN
|
|
///
|
|
/// @param data the data that has been received from the socket.
|
|
///
|
|
|
|
virtual void onDataReceived(std::string data); ///< Called when data is received from the socket.
|
|
|
|
///
|
|
///
|
|
///
|
|
|
|
virtual void onDataReceived(coreutils::ZString &data);
|
|
|
|
///
|
|
/// receiveData will read the data from the socket and place it in the socket buffer.
|
|
/// TLS layer overrides this to be able to read from SSL.
|
|
///
|
|
|
|
virtual void receiveData(coreutils::ZString &buffer);
|
|
|
|
///
|
|
/// sendData writes data to the socket descriptor. TLS layer overrides this to
|
|
/// write through SSL instead of a raw socket write.
|
|
///
|
|
/// @return The number of bytes written, or -1 on error.
|
|
///
|
|
|
|
virtual int sendData(const char *data, int length);
|
|
|
|
private:
|
|
|
|
std::string text;
|
|
int descriptor = -1;
|
|
std::mutex outlock;
|
|
bool readHangup = false;
|
|
volatile bool inHandler = false;
|
|
|
|
//-------------------------------------------------------------------------------------
|
|
// the writeSocket is called when epoll has received a write request for a socket.
|
|
// Writing data to this socket is queued in the streambuf and permission is requested
|
|
// to write to the socket. This routine handles the writing of the streambuf data
|
|
// buffer to the socket.
|
|
//-------------------------------------------------------------------------------------
|
|
|
|
void writeSocket();
|
|
|
|
// int_type underflow();
|
|
// int_type uflow();
|
|
// int_type pbackfail(int_type ch);
|
|
// streamsize showmanyc();
|
|
|
|
char *buffer; // This is a pointer to the managed buffer space.
|
|
int length; // This is the length of the buffer.
|
|
|
|
std::queue<std::string> fifo;
|
|
|
|
// Counts consecutive writeSocket() calls that sent zero bytes for
|
|
// the SAME queued fifo entry (SSL_ERROR_WANT_READ from
|
|
// TLS::sendData() is the confirmed real case - see writeSocket()'s
|
|
// own doc comment). resetSocket() re-arms EPOLLWRNORM whenever the
|
|
// fifo is non-empty regardless of WHY the last send failed, and an
|
|
// already-writable TCP socket (the common case) makes EPOLLWRNORM
|
|
// fire again essentially immediately - so a send that keeps
|
|
// failing for a reason unrelated to socket writability (like SSL
|
|
// needing a read first) spins this cycle as fast as the CPU can
|
|
// run it, forever, with zero actual progress. Confirmed live: one
|
|
// stuck connection generated a 55GB, then a 12.9GB debug log
|
|
// before being noticed, at roughly 20 log lines per millisecond.
|
|
// Reset to 0 on any successful send (even a partial one - real
|
|
// progress happened); past the threshold, the connection is
|
|
// clearly never going to un-stick itself and gets shut down.
|
|
int consecutiveWriteStalls = 0;
|
|
|
|
void resetSocket();
|
|
|
|
std::mutex lock;
|
|
|
|
};
|
|
|
|
}
|
|
|
|
#endif
|
|
|